feat: Adds a 'Create PR' button to the button bar after attempt_completion #9021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannesrudolph
added
the
Issue/PR - Triage
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
- Remove /create-pr built-in slash command from built-in-commands.ts
- Add CREATE_PR Support Prompt type with same functionality
- Update Chat UI button to use supportPrompt.create('CREATE_PR')
- Add CREATE_PR translations to all 17 locales
- Revert unrelated slash command tool changes to original state
- Add comprehensive tests for CREATE_PR prompt
The Create PR button now uses a customizable prompt template editable in Settings > Prompts, while maintaining the same user experience.
daniel-lxs
approved these changes
Nov 4, 2025
…llation confirmation
dosubot
bot
added
size:L
|
Review complete. Latest commit is a clean Italian translation typo fix. Previous UX issue remains unresolved:
Mention @roomote in a comment to trigger your PR Fixer agent and make changes to this pull request. |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
hannesrudolph
added
PR - Needs Review
and removed
Issue/PR - Triage
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
Comment on lines
+744
to
+750
| // Check if primary button is "Create PR" | ||
| if (primaryButtonText === t("chat:createPR.title")) { | ||
| // Mark that PR creation was requested | ||
| setPrCreationRequested(true) | ||
| // Send message using the Support Prompt for PR creation | ||
| const text = supportPrompt.create("CREATE_PR", {}, customSupportPrompts) | ||
| handleSendMessage(text, []) |
There was a problem hiding this comment.
Clicking the "Create PR" button clears any text the user has typed in the input field. This differs from the follow-up suggestion behavior (lines 1514-1521) which preserves user input. Users may have typed additional context or instructions before clicking "Create PR" and will lose that text unexpectedly.
Fix it with Roo Code or mention @roomote and request a fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In an effort to help fit within users' workflows, this changes the UI after
attempt_completionto show these buttons, instead of just "Start New Task"Which then goes through a workflow which creates a PR on behalf of the user (if gh cli tools are available) or pushes to the remote branch and shares a link to create the PR.
To do that:
/create-pr)git.tsutil file to be better aware of what's a git repo workspace or not, namely to be aware of worktrees (which is worthwhile on its own – and I'm a heavy worktree user)attempt_completionand, if it is, shows the button.Missing nice-to-have: I'm showing the
Create PRbutton every time it's eligible according to what's described above. But ideally we should only show it if it's a git repo and either there are unstaged changes or there are commits in a non-main/master branch. Checking for that seemed too complex for now, it seems non-blocking but a good improvement.Test Procedure
Create PRbuttonImportant
Adds a 'Create PR' button in the UI for GitHub repositories, with supporting command and localization updates.
ChatView.tsxfor GitHub repositories.attempt_completionif in a GitHub repo./create-prcommand to facilitate PR creation.ClineProviderto check for GitHub repository status.This description was created by
for 44a7786. You can customize this summary. It will automatically update as commits are pushed.